Skip to content

Enable eager authentication#128

Draft
thepatrickchin wants to merge 8 commits intoNVIDIA:mainfrom
thepatrickchin:feat/eager-auth
Draft

Enable eager authentication#128
thepatrickchin wants to merge 8 commits intoNVIDIA:mainfrom
thepatrickchin:feat/eager-auth

Conversation

@thepatrickchin
Copy link
Copy Markdown
Member

@thepatrickchin thepatrickchin commented Apr 2, 2026

Description

This is a complementary PR for NVIDIA/NeMo-Agent-Toolkit#1837
Closes NVIDIA/NeMo-Agent-Toolkit#1836

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 2, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@thepatrickchin
feat: add option to open OAuth login on same tab
9ba1e7e 
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
@thepatrickchin
feat: reconnect WS and resubmit message after returning from login
2805e6b 
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
@thepatrickchin
fix: display auth cancellation message when user clicks back
c5c4984 
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
@thepatrickchin
feat: display cancellation reason
31f26b4 
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
@thepatrickchin
refactor: rename use_popup_auth to use_redirect_auth and negate logic
db82f96 
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
@thepatrickchin
feat: enable pre-authorization before prompt is submitted
57b8af3 
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
@thepatrickchin
fix: prevent auth redirect loop when user cancels or declines consent
21245f8 
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
@thepatrickchin
refactor: rename pre_auth to eager_auth
379296d 
Signed-off-by: Patrick Chin <8509935+thepatrickchin@users.noreply.github.com>
@dagardner-nv dagardner-nv added non-breaking Non-breaking change feature request New feature or request labels Apr 24, 2026
@dagardner-nv
Copy link
Copy Markdown
Contributor

dagardner-nv commented Apr 24, 2026

/ok to test 1eb4975

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 24, 2026

/ok to test 1eb4975

@dagardner-nv, there was an error processing your request: E2

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/

@dagardner-nv
Copy link
Copy Markdown
Contributor

dagardner-nv commented Apr 24, 2026

/ok to test 379296d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

feature request New feature or request non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add option to enable eager authentication

2 participants

@thepatrickchin @dagardner-nv